Render canvas on provided container

[pedroalmeida415]

It'd be nice if we could give an ID or an element itself to the initializer to tell it where to render the canvas, instead of just creating and appending a new canvas to the body

[btco]

Good idea!

[btco]

Thinking about this, but it's non-trivial because the canvas needs to have a pretty specific configuration in terms of width, height, etc to match the config...

[photonstorm]

I think the request is just asking to pass an id where the canvas will be appended (it's parent element) as opposed to adding it directly in the body.

I agree there's no point adding a feature to pass in a canvas element to actually use, but a parent makes sense.

[btco]

Ahh yes, that makes sense, but still the code is currently hard-coded to have the canvas the same size as window.innerWidth x window.innerHeight (cropped to aspect). If I refactor that a bit, I think I can then accept a parent element.

I will look into it. Thanks!

Le sam. 21 oct. 2023 à 10:58, Richard Davey @.***> a écrit :

I think the request is just asking to pass an id where the canvas will be appended (it's parent element) as opposed to adding it directly in the body.

I agree there's no point adding a feature to pass in a canvas element to actually use, but a parent makes sense.

— Reply to this email directly, view it on GitHub https://github.com/btco/qx82/issues/4#issuecomment-1773724060, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBXHTGCJL64SEVCWJ4RP63YAOFD5AVCNFSM6AAAAAA6DH2XFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTG4ZDIMBWGA . You are receiving this because you commented.Message ID: @.***>

[btco]

Just a note that I'm currently working on this and expect to have a solution soon-ish.

[btco]

There is now also a way to specify:

• What element the canvas should be added to (CONFIG.CANVAS_SETTINGS.CONTAINER)
• Whether or not QX82 should auto-position and/or auto-size the canvas (CONFIG.CANVAS_SETTINGS.AUTO_POSITION and AUTO_SIZE)
• What ID and CSS classes to assign to the canvas (CONFIG.CANVAS_SETTINGS.CANVAS_ID and CANVAS_CLASSES).