Improve toggle switch - Githubissues

btcpayserver / btcpayserver-design

BTCPay Server Design System

https://design.btcpayserver.org/

23 stars 10 forks source link

Improve toggle switch #22

Closed dstrukt closed 2 years ago

dstrukt commented 2 years ago

[ ] Add helper text variant
[ ] Better formatting

dstrukt commented 2 years ago

Updates.

dennisreimann commented 2 years ago

What's the diffrence with the "Better formatting"?

The helper text variant can be solved with the general Bootstrap layout utilities, we do not ned to define a custom component for that imho.

dennisreimann commented 2 years ago

Can we close this? As far as I see we don't need to customize the component and should use the Bootstrap utils for applying the helper text.

dstrukt commented 2 years ago

That's a fair point .. took a look at the code of how we're implementing the switches and agree with you, as long as it's consistent in the implementation, which it seemed to be, I'm cool with that.

I suppose the only other changes to the switches could be off/on hover states, but that's just more minor interactive stuff that could be done at any time.