search

btcpayserver / btcpayserver-design

BTCPay Server Design System
https://design.btcpayserver.org/
23 stars 10 forks source link

Improve state colored table rows #49

Closed dstrukt closed 1 year ago

dstrukt commented 2 years ago

As reported by wouter.

Tracking here.

image

Mocks TODO.

dennisreimann commented 2 years ago

The table-striped class should not be applied here, because that leads to the slightly different colors when there are multiple table-danger rows (as in this case) following each other.

In general we shouldn't use the background color here, but use the text-success and text-danger classes for that. We do that on the wallet transactions list and when sending a transaction too — so that'd be consistent and simpler.

dstrukt commented 2 years ago

Agree, I wanted to track to make sure we handle this case, either by styling as we see fit, or making sure it can’t be styled a way we don’t want .. or potentially prevent that styling as a note in the design system/guidelines.

lukeist commented 1 year ago

I'd like to help. Please let me know how.

dennisreimann commented 1 year ago

Fixed with the recent Bootstrap upgrade.