Closed arshbot closed 4 months ago
For some reason banner is still broken in preview despite
@dennisreimann what is required in order to properly render an image from external repo to /docs?
Dumb question, but when you tested did you rerun ./setup-deps.sh?
Just went through and can verify the url in your commits (https://github.com/btcpayserver/nopcommerce/blob/f24ed2182ae192f8cc81e70c6161020a05984257/nopCommerceAcceptBitcoin.png
) doesn't work because they link to the github page containing the image, not the image itself.
tested again with params raw=true in the url (https://github.com/btcpayserver/nopcommerce/blob/main/nopCommerceAcceptBitcoin.png?raw=true
) and it worked again locally.
If it still isn't working, could you check $PROJECT_PATH/docs/Nopcommerce/README.md
and paste line 7? If it's the right url it really should work unless I'm missing something
the grandnode url you added really should have worked...
hey @arshbot I am lost, I'll merge this one and see if it's caching related. It seems raw github should work no idea why netlify preview doesn't show it.
Can confirm it works now, I assume caching with Netlify previews was the problem, thanks for contribution 🎉
Tackles https://github.com/btcpayserver/btcpayserver-doc/issues/1372
Dependent on the following PRs: