Compatibility with Symfony 4.x + upgraded PHP to stable

btcpayserver / btcpayserver-php-client

PHP implementation for the BTCPayServer cryptographically secure RESTful API

MIT License

29 stars 33 forks source link

Compatibility with Symfony 4.x + upgraded PHP to stable #15

Closed woutersamaey closed 5 years ago

woutersamaey commented 5 years ago

Symfony 4 support should be fine too. We added Symfony 3, but now need 4 as well. Updated PHP as well to a stable & supported version. PHP 5.4 is long since end of life.

woutersamaey commented 5 years ago

@NicolasDorier are you getting notifications now? I remember you didn't get any previously.

woutersamaey commented 5 years ago

@NicolasDorier can you accept this please? This fixes #8 and has already been tested by @elvismdev in his fork of this repo as he mentions in the issue.

I'm waiting on this to release my Magento 2 module (and I prefer not to fork this repo again unless I really have to).

NicolasDorier commented 5 years ago

I am not well placed to review this, ping @psyb0t .

@psyb0t would you consider giving @woutersamaey rights over this repo? He is contributing and working quite a lot in this area.

psyb0t commented 5 years ago

@NicolasDorier everything seems okay. Would be great to have him on too. I currently have lots on my hands work-related and I didn't get any chance to review anything here yet for real, sorry.

woutersamaey commented 5 years ago

Would love to help out.

At present I have:

A substantial merge that would update this repo to the latest logic of BitPay (meaning that we take their latest changes and apply them here - it's not that much, but this repo is outdated due to it being an old fork). I tested the BitPay code and it works with BTCPay, so no danger.
A desire to make this repo work with 0 dependancies. Why we need Symfony for a simple API like this doesn't make much sense to me. The Symfony stuff is only used in 1 or 2 classes, so let's find a way to refactor and drop the requirement.
Any new features that BTCPay gets, can be integrated here, breaking away from BitPay entirely and giving us our own path to innovate.

NicolasDorier commented 5 years ago

@psyb0t thanks, I just added @woutersamaey as admin also.

@woutersamaey I don't know why the deps to symfony is so I can't really comment or anything.