Closed woutersamaey closed 5 years ago
@NicolasDorier are you getting notifications now? I remember you didn't get any previously.
@NicolasDorier can you accept this please? This fixes #8 and has already been tested by @elvismdev in his fork of this repo as he mentions in the issue.
I'm waiting on this to release my Magento 2 module (and I prefer not to fork this repo again unless I really have to).
I am not well placed to review this, ping @psyb0t .
@psyb0t would you consider giving @woutersamaey rights over this repo? He is contributing and working quite a lot in this area.
@NicolasDorier everything seems okay. Would be great to have him on too. I currently have lots on my hands work-related and I didn't get any chance to review anything here yet for real, sorry.
Would love to help out.
At present I have:
@psyb0t thanks, I just added @woutersamaey as admin also.
@woutersamaey I don't know why the deps to symfony is so I can't really comment or anything.
Symfony 4 support should be fine too. We added Symfony 3, but now need 4 as well. Updated PHP as well to a stable & supported version. PHP 5.4 is long since end of life.