Fixing SSL bundle problem for expired lets encrypt root cert.

btcpayserver / btcpayserver-php-client

PHP implementation for the BTCPayServer cryptographically secure RESTful API

MIT License

29 stars 33 forks source link

Fixing SSL bundle problem for expired lets encrypt root cert. #52

Closed ndeet closed 2 years ago

ndeet commented 2 years ago

For more info see also the original bitpay fork commit https://github.com/btcpayserver/php-bitpay-client/commit/16862d2ed624e20f650173ec904614dcc8b45c6b

woutersamaey commented 2 years ago

So if I understand correctly we will be using the cert bundle that's installed on the server instead of overriding the bundle to a file that was pre-packaged in this repo? Hell yeah!

ndeet commented 2 years ago

Yes exactly. I can only assume that they built in the lets encrypt ssl root certs back in the day because the support from linux distributions was not great back then but nowadays if you have a patched distribution it should be no problem at all. Maybe they also had some use case of their own servers with special certificates, no idea but using the handcrafted bundle seems to be outdated.

BitcoinMitchell commented 2 years ago

Nice fix! I'll update prestashop-plugin.