search

btcpayserver / magento2-plugin

4 stars 5 forks source link

Fix bug creating new webhook on each order #16

Closed ndeet closed 1 year ago

ndeet commented 1 year ago

Some calls seems were not updated to breaking changes of v2 of the php library. This caused the webhook check to always return null and a new webhook was created on each checkout or config save. This lead also to DoS of the shop from BTCPay because of hundrets of webhooks firing at the same time. (eg. om mainnet demo one store had 1800 of them)

Fixes #15

ndeet commented 1 year ago

Thanks for reviewing @woutersamaey do you want to merge and do an release? I currently do not have any rights on this repo and can't merge. If you want me to do it, let me know and I will figure it out.