Use order id as a reference consistently

btcpayserver / woocommerce-plugin

Plugin for connecting Woocommerce with BTCPayServer

https://btcpayserver.org/

Other

51 stars 41 forks source link

Closed dennisreimann closed 3 years ago

dennisreimann commented 3 years ago

Builds on this proposal and removes the ambiguity of order ID and number:

Replaces references to the order number with the actual order ID
Removes the woocommerce_order_id_from_number, because it is obsolete then
Adds order number as well as other custom data for reference to the posData field of the invoice
Changes logging output to mention order ID as well as number

This relates to and potentially closes issue #45. (another discussion about this on Mattermost)

dennisreimann commented 3 years ago

Tested the first commit by uploading the plugin to my shop, that worked well :)

Now waiting for another order that will get processed with the latest changes and a custom order number plugin installed.

dennisreimann commented 3 years ago

Alright, next order – this time with the custom order number plugin enabled. ()Oder ID and number being different here)

Works well – have to fix the display in BTCPay though. Will take care of that with another PR.

order

Kukks commented 3 years ago

merged! next up we will fix the docs once we release a new version to remove the mention of special case of custom order support