btcpayserver / xenforo

MIT License
5 stars 4 forks source link

Additional events in webhooks #1

Closed ndeet closed 7 months ago

ndeet commented 8 months ago

Hi! First of all, thank you very much for building this great integration for BTCPay Server :hugs:

On processing the webhooks it only listenens to the InvoiceSettled event at the moment which means that a few cases are not covered

Not sure if XF has some concept of order states so maybe not all usecases can or should be covered but you can see in our WooCommerce plugin how to cover all cases

You likely would not need all of it but I would at least additionally cover the case of an expired invoice paid late, which will not fire InvoiceSettled but rather a InvoiceExpired followed by an InvoicePaymentSettled

Let me know if you have any questions.

Thank you.

021-projects commented 8 months ago

Hey! Thanks to the BTCPay Server team for its existence :)

In XenForo there is no concept of purchase statuses: payment is either received or not. Otherwise we can just notify about different things in the payment provider log. I think I'll just add logs for some of the situations you described

021-projects commented 7 months ago

https://github.com/btcpayserver/xenforo/commit/8443ff5ba9138982b53c4d24b2baeae9dfe79d88