search

btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.18k stars 2.34k forks source link

simnet rejects transactions based on 'priority' #1593

Open DariusParvin opened 4 years ago

DariusParvin commented 4 years ago

Currently, btcd rejects transactions based on their priority. e.g. "\<txid> has insufficient priority (0 <= 5.76e+07)"

I believe this is an outdated method for rejecting transactions that's not widely used anymore.

I'm not sure if btcd on mainnet mode uses the same 'priority' criteria, but ideally this would be updated to match the latest default bitcoin core standardness rules.

DariusParvin commented 3 years ago

Related to this, I'm finding that CPFP doesn't always work at bumping up a transaction into the next block. This is because even if the new fee rate is higher than the other transactions in the mempool, it might still have a lower 'priority', e.g. if the other pending transactions are all of a much higher value.

Roasbeef commented 3 years ago

Related to this, I'm finding that CPFP doesn't always work at bumping up a transaction into the next block.

The simnet miner doesn't implement CPFP as defined.

You're correct that Bitcoin Core has done away with priority for the most part, but its still present in our miner.