coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4002408802
- 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.08%) to 55.248%
| Totals | |
|---|---|
| Change from base Build 3968292573: | 0.08% |
| Covered Lines: | 26610 |
| Relevant Lines: | 48165 |
In this PR, we fix a bug in RawTxInTaprootSignature that would cause the function to not properly apply the sighash flag for non-default sighash signatures. The logic would end up applying
0x00as a mask, which will always be0x00on the other end.The RawTxInTapscriptSignature function was correct, though it had the ordering switched as it applies the sighash if the type doesn't equal default.
The second commit adds tests that fail w/o the first commit. Without the first commit, the test fails for the keyspend sigs as they're always 64 bytes, since the sighash wasn't added for non-default types.