btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.11k stars 2.32k forks source link

Export MakeScritpNum, AsSmallInt, and IsSmallInt #1956

Closed martonp closed 1 year ago

martonp commented 1 year ago

I would like to import these functions to use in https://github.com/decred/dcrdex/pull/2196. The exact same functions are exported in dcrd, but I'd rather import from here on the off chance that something changes.

Thanks!

jcvernaleo commented 1 year ago

The reasoning makes sense to me. Just waiting for the GH actions to run then I'll approve.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4326594580


Changes Missing Coverage Covered Lines Changed/Added Lines %
txscript/standard.go 8 11 72.73%
<!-- Total: 16 19 84.21% -->
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.75%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 4296367184: 0.07%
Covered Lines: 26654
Relevant Lines: 48204

💛 - Coveralls