Closed lindlof closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
rpcserver.go | 0 | 15 | 0.0% | ||
<!-- | Total: | 0 | 15 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
rpcserver.go | 3 | 0.26% | ||
peer/peer.go | 7 | 73.2% | ||
<!-- | Total: | 10 | --> |
Totals | |
---|---|
Change from base Build 5075515644: | -0.02% |
Covered Lines: | 26665 |
Relevant Lines: | 48261 |
PR looks fine! I wanted to open a similar PR because we now receive the address field from the node and don't have it in the result.
Okay @guggero I've left the deprecated fields in. The commit to remove them exists in https://github.com/lindlof/btcd/commit/faae23164d635ea6145f2108a96d4673e2811fc3
@guggero @bog-h is there anything preventing from merging this in? This would be really helpful for me
I guess another review from someone who has more experience with the code base than myself would be great. Any volunteers, @Roasbeef, @kcalvinalvin, @chappjc?
ACK fcf291947d51896664e848526482983a5cbb72db26fa1d78649c3d051cf602fc
Also tested by calling getrawtransaction
, decoderawtransaction
, and gettxout
to a Bitcoin Core node. Works well.
Bitcoin Core has added
address
field and removedaddresses
andreqSigs
rpc response fields. The fields were deprecated on version 22 and they've been removed from version 23. For instance, the following methods are affected:This PR adds the new
address
and deprecates the removed fields.Closes #1874