search

btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.2k stars 2.36k forks source link

multi: remove repetitive the #1998

Closed cuishuang closed 1 year ago

kcalvinalvin commented 1 year ago

Could you change the commit message to:

multi: remove repetitive the

LGTM otherwise

cuishuang commented 1 year ago

Could you change the commit message to:

multi: remove repetitive the

LGTM otherwise

Of course. Done

kcalvinalvin commented 1 year ago

Seems like that one test that occasionally fails is failing.

I can't run the CI again but you could trigger the CI by an empty

git commit --amend and change the commit hash.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5375193722

Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 5342979571: 0.002%
Covered Lines: 26648
Relevant Lines: 48251
💛 - Coveralls
guggero commented 1 year ago

Can confirm the CI failure was a flake.