search

btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.1k stars 2.31k forks source link

fix: missing sighashtype when finalizing taproot keyspend signature #2006

Closed 0xEclair closed 11 months ago

0xEclair commented 11 months ago

Add sighash flag at end of taproot keyspend signature(witness).

Related: #2004

Fixes #2005

0xEclair commented 11 months ago

Thanks for the review @Roasbeef. Addressed your comments.

0xEclair commented 11 months ago

Thanks for the review @guggero. Addressed your comments.

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5574614891

Totals Coverage Status
Change from base Build 5525483102: 0.07%
Covered Lines: 26729
Relevant Lines: 48332
💛 - Coveralls
0xEclair commented 11 months ago

PTAL @Roasbeef :)