btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.1k stars 2.31k forks source link

refactor: set strconv.ParseFloat bitsize to 64 #2062

Closed lilasxie closed 1 month ago

lilasxie commented 7 months ago

strconv.ParseFloat will always treat bizSize parameter as 64 if we don't set it to 32, it's odd to set it to 0, although this won't affect the result

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 9337080347

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
peer/peer.go 15 73.49%
<!-- Total: 15 -->
Totals Coverage Status
Change from base Build 9219767772: -0.03%
Covered Lines: 29607
Relevant Lines: 51941

💛 - Coveralls
lilasxie commented 1 month ago

@guggero Hi sir, can we get this merged then~

guggero commented 1 month ago

Can you please remove the merge commit by rebasing?

lilasxie commented 1 month ago

Can you please remove the merge commit by rebasing?

@guggero Hi sir, suggestion addressed