Closed yyforyongyu closed 7 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
rpcclient/infrastructure.go | 0 | 9 | 0.0% | ||
rpcclient/backend_version.go | 43 | 65 | 66.15% | ||
rpcclient/rawtransactions.go | 0 | 45 | 0.0% | ||
<!-- | Total: | 93 | 169 | 55.03% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
rpcclient/infrastructure.go | 1 | 39.21% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 8057525961: | 0.03% |
Covered Lines: | 29284 |
Relevant Lines: | 51599 |
cc: @Crypt-iQ for review
cc: @guggero
Nice pr @yyforyongyu I like the progression.
question/suggestion: Do you think we should separate the implementations of the Backend version interface into separate files? like bitcoin.go and btcd.go in the same folder. In the future if we want to track more backends we just create a new file and that way it is easier to follow?
Do you think we should separate the implementations of the Backend version interface into separate files? like bitcoin.go and btcd.go in the same folder. In the future if we want to track more backends we just create a new file and that way it is easier to follow?
@Chinwendu20, I think if we did that, we'd want to add a version prefix/suffix to the file names, so it's clear that this is code for parsing the versions, rather than a bitcoind
specific implementation of something.
This PR adds the RPC
gettxspendingprevout
forbtcd
so we can do mempool lookups. This RPC is also ported to therpcclient
to replace the raw request made on the btcwallet side.In addition, we now start to track
btcd
versions inrpcclient
to make sure RPC updates are handled properly.