btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.09k stars 2.31k forks source link

Add new serialized pubkey type #2156

Closed ffranr closed 2 months ago

ffranr commented 2 months ago

This commit adds a new type called SerializedKey.

A serialized type is useful when using public keys as map keys. This is because functionally identical public keys can have different internal representations. These differences would cause the map to treat them as different keys.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8528940528

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
btcec/pubkey.go 0 20 0.0%
<!-- Total: 0 20 0.0% -->
Files with Coverage Reduction New Missed Lines %
peer/peer.go 9 73.86%
wire/msgaddrv2.go 13 56.9%
wire/netaddressv2.go 20 74.45%
<!-- Total: 42 -->
Totals Coverage Status
Change from base Build 8452827211: -0.09%
Covered Lines: 29393
Relevant Lines: 51757

💛 - Coveralls
Roasbeef commented 2 months ago

Will tag a new btcec version after this is merged.

Roasbeef commented 2 months ago
To github.com:btcsuite/btcd.git
 * [new tag]             btcec/v2.3.3 -> btcec/v2.3.3