btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.09k stars 2.31k forks source link

psbt: decode keytype as compact size #2206

Closed guggero closed 3 days ago

guggero commented 3 days ago

Fixes #2199.

Previous to this fix the keytype was only interpreted as a single byte, even though BIP-0174 states it is to be parsed as a CompactSize/VarInt.

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9661948822

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/utils.go 11 14 78.57%
<!-- Total: 11 14 78.57% -->
Files with Coverage Reduction New Missed Lines %
btcutil/psbt/utils.go 1 82.99%
mempool/mempool.go 1 66.67%
connmgr/connmanager.go 2 86.62%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9610935276: -0.001%
Covered Lines: 29804
Relevant Lines: 52063

💛 - Coveralls
coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9663927080

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/utils.go 11 14 78.57%
<!-- Total: 11 14 78.57% -->
Files with Coverage Reduction New Missed Lines %
btcutil/psbt/utils.go 1 82.99%
mempool/mempool.go 1 66.67%
connmgr/connmanager.go 3 86.27%
peer/peer.go 9 73.49%
<!-- Total: 14 -->
Totals Coverage Status
Change from base Build 9610935276: -0.02%
Covered Lines: 29793
Relevant Lines: 52063

💛 - Coveralls