Closed ziggie1984 closed 1 month ago
FYI see https://github.com/bitcoin/bitcoin/pull/29845 for more context. Old behaviour can temporarily be reverted via -deprecatedrpc=warnings
as per the release notes but this will be removed in a future version so best to upgrade when you can.
See also https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#versioning.
Where possible, these changes are also documented in the help RPC, see e.g.
./src/bitcoin-cli -regtest help getnetworkinfo | grep warnings
"warnings" : [ (json array) any network and blockchain warnings (run with `-deprecatedrpc=warnings` to return the latest warning as a single string)
. We should adapt the btcd code to account for this however I am not sure how we should do this in a backwards compatible manner. Any suggestions from prior RPC updates of the core software ?
See: https://github.com/btcsuite/btcd/issues/1934
We no longer commit to staying 1:1 in step with all the bitcoind
related RPC changes. Even just on the wallet side, there've been a bunch over the past few years, and btcd
doesn't integrate its own wallet, so there isn't as strong a case to mirror all the changes there.
For a change like this, one could consider adding a new field for the new value. Not sure how upstream clients that are depending (what do people even use it for today?) on the warnings
field will handle the change in general through (string to slice).
The current master branch of bitcoin-core introduced a new field into the
getnetworkinfo
rpc json-response. We should adapt the btcd code to account for this however I am not sure how we should do this in a backwards compatible manner. Any suggestions from prior RPC updates of the core software ?Thanks @michael1011 for pointing this out.