search

btcsuite / btcd

An alternative full node bitcoin implementation written in Go (golang)
https://github.com/btcsuite/btcd/blob/master/README.md
ISC License
6.27k stars 2.37k forks source link

Send subscribed tx notifications in block connected notification #602

Open jrick opened 8 years ago

jrick commented 8 years ago

This will be required for upcoming changes to btcwallet to the processing of transaction notifications.

I'll begin work on this and create a PR, but it will be a breaking API change (no more recvtx/redeemingtx notifications for transactions from an attached block) and can't be merged until the wallet changes are ready.

jrick commented 8 years ago

I'd also like to note that while btcwallet can attempt to combine all of these notifications into a single one so it can process one block at a time, besides being totally silly (why combine what was already combined earlier) I'm not even sure it's possible to do in all cases since transaction notifications from the rescan also make use of the same recvtx/redeemingtx notifications. My change will leave those be, and wallet will treat them as loose transactions not associated with the attached block notification.