Correct BIP-32 derivation issue

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types

480 stars 410 forks source link

Correct BIP-32 derivation issue #182

Closed devrandom closed 3 years ago

devrandom commented 4 years ago

Fixes issue #172.

This issue affects 1 in 256 hardened key derivations. For standard BIP-44 accounts, this affects the coin and account derivations, so 1 in 128 accounts will not be compatible with other BIP-44 implementations.

The intention is that wallet implementations using btcutil can use the IsAffectedByIssue172 call to check if they are affected, and potentially migrate (or ask the user to create a new wallet).

silencer-Tsai commented 4 years ago

Well done!

Roasbeef commented 3 years ago

cc @guggero