allocate less in Encode

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types

475 stars 408 forks source link

allocate less in Encode #185

Closed josharian closed 3 years ago

onyb commented 3 years ago

@josharian Needs a rebase following #183.

josharian commented 3 years ago

If I take the time to rebase will someone review and merge? It has been sitting unreviewed for two months.

jcvernaleo commented 3 years ago

Hi @josharian

Sorry for letting this one sit. We are getting better at prioritizing and not missing PRs but aren't perfect at it yet so sometimes ones get missed. As our backlog gets smaller I'm hoping for it to happen less though. At least that is my hope :)

Anyway, yes, please rebase and I'll make sure we review it. Will add it to our project board to make sure we don't miss it again.

josharian commented 3 years ago

Done. #183 picked up the lowest hanging fruit that this PR addressed, but there was a still a small performance benefit available.