search

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types
480 stars 410 forks source link

Rename module cosmos/btcutil #204

Closed conr2d closed 3 years ago

conr2d commented 3 years ago

The forked module is renamed github.com/cosmos/btcutil.

I tried to remove the original module dependency completely, but btcutil depends on github.com/btcsuite/btcd and btcd has type assertions with github.com/btcsuite/btcutil.

https://github.com/btcsuite/btcd/blob/master/txscript/standard.go#L440-L482

If we want to exclude the original module from dependencies, it's necessary to fork btcd, too. (not ideal)

Any other changes are simply replacing module name, but in gcs/builder/builder_test.go, btcutil is not this module, but the original one.

conr2d commented 3 years ago

This PR is not for the upstream. Sorry for annoying.

jcvernaleo commented 3 years ago

@conr2d no worries. We've all done it at least once :)