txsort: Convert tests, optimize, and cleanup code.

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types

477 stars 410 forks source link

txsort: Convert tests, optimize, and cleanup code. #60

Closed davecgh closed 8 years ago

davecgh commented 8 years ago

Move hex for test txns into separate files in the testdata directory
Convert tests to table-driven tests
Make comments more consistent with the rest of the codebase
Optimize the input sorting function to perform the hash equivalence check before reversing the bytes so it can be avoided in that case

davecgh commented 8 years ago

Coveralls failure is a false positive. The overall coverage of the entire btcutil repo went down as a result of the number of lines changed, however the txsort package still has 100% coverage.

jrick commented 8 years ago