search

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types
477 stars 410 forks source link

hdkeychain: Update NewMaster to accept network. #66

Closed davecgh closed 8 years ago

davecgh commented 8 years ago

This changes the NewMaster function to accept the network the generated extended master key is associated with. This could previously be done by calling SetNet on the returned extended key, but that approach is more error prone since it is easy for a caller to forget to do it or never know they should to begin with.

Closes #65

Review on Reviewable

dajohi commented 8 years ago

Since the API is changing, should you drop SetNet, or is it still useful somehow?

davecgh commented 8 years ago

It's still useful in some circumstances.

dajohi commented 8 years ago

OK, and OK on the PR.

cjepson commented 8 years ago

ACK

davecgh commented 8 years ago

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io