search

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types
477 stars 410 forks source link

txsort: BIPLI01 has been accepted as BIP69, update README as such #70

Closed Roasbeef closed 8 years ago

Roasbeef commented 8 years ago

BIPLI01 has been accepted as BIP0069, so update the README, comments, tests, and testdata files as such.

This change is Reviewable

davecgh commented 8 years ago

Thanks for the PR. Would you please make the commit message match the Model Git Commit Message format as documented in the code contribution guidelines?

In particular, the summary is too long.

The following would probably work:

txsort: Update README for BIP0069 acceptance.

BIPLI01 has been accepted as BIP0069, so update the README as such.
davecgh commented 8 years ago

Also, if you would rebase it to the latest master, it will resolve the TravisCI build failures as I just merged a couple of PRs to update it to the most recent Go versions.

davecgh commented 8 years ago

Oh, while here, it might make sense to update the comments on the functions in txsort.go too. I just noticed they say BIPLI01.

davecgh commented 8 years ago

There is also another reference in doc.go.

Roasbeef commented 8 years ago

Just pushed an update. I've fixed the comments in txsort.go, txsort_test.go, and doc.go. Additionally, I've renamed the test files used for the table driven tests in the testdata directory.

davecgh commented 8 years ago

Thanks. Looks good now.

OK