search

btcsuite / btcutil

Provides bitcoin-specific convenience functions and types
477 stars 410 forks source link

Exported ExtendedKey #99

Closed cpacia closed 7 years ago

cpacia commented 7 years ago

The ExtendedKey struct in the hdkeychain package has all private fields. This is a bit problematic as my use case requires using a custom chaincode.

Would you accept a PR changing newExtendedKey to exported so that people can create custom extended keys outside the package?

davecgh commented 7 years ago

I don't have any objections to that. I would ask that you update the comment accordingly to say something along the lines that it should only be used for custom applications and typically callers should use NewMaster, Child, and Neuter.