btcsuite / btcwallet

A secure bitcoin wallet daemon written in Go (golang)
ISC License
1.13k stars 576 forks source link

when write bucket failed, why return nil instead of err? #936

Open czh0526 opened 3 months ago

czh0526 commented 3 months ago

the error is in file waddrmgr/db.go at line 1216

func putAddrAccountIndex(...) error { ....

    // Write account keyed by address hash
err = bucket.Put(addrHash, uint32ToBytes(account))
if err != nil {
    return nil
}

     .....

}

yyforyongyu commented 3 months ago

think it's a mistake we should fix🤔