search

btcven / locha-p2p

Apache License 2.0
8 stars 1 forks source link

protobuf was added to lochap2pd #53

Closed xkevin190 closed 3 years ago

jeandudey commented 3 years ago

Could we move the protobuf serialization to the src/ dir (locha-p2p crate)? So that way we share code between the app and the command line program, e.g.: we modify the send_message logic on the Runtime to accept the parameters we need in a message.

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (246f72e) into master (6a3a755) will decrease coverage by 0.06%. The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   21.14%   21.08%   -0.07%     
==========================================
  Files          12       12              
  Lines         610      607       -3     
==========================================
- Hits          129      128       -1     
+ Misses        481      479       -2
Impacted Files Coverage Δ
locha-p2pd/src/main.rs 0.00% <0.00%> (ø)
src/p2p/behaviour.rs 48.55% <0.00%> (+0.34%) :arrow_up:
src/p2p/pubsub.rs 100.00% <ø> (ø)
src/runtime.rs 0.00% <0.00%> (ø)
src/runtime/events.rs 0.00% <0.00%> (ø)
src/transport.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0f8f71...659490e. Read the comment docs.