search

btd / esbuild-visualizer

Create chart of dependencies in your bundle
MIT License
66 stars 5 forks source link

make nanoid package a dependency instead of a devDependency #3

Closed okize closed 3 years ago

okize commented 3 years ago

after I installed esbuild-visualizer I tried to run it and got this error:

$ yarn build:analyze
yarn run v1.22.11
$ esbuild-visualizer --metadata ./meta.json
internal/modules/cjs/loader.js:883
  throw err;
  ^

Error: Cannot find module 'nanoid/non-secure'
Require stack:
- FILEPATH/node_modules/esbuild-visualizer/dist/plugin/module-mapper.js
- FILEPATH/node_modules/esbuild-visualizer/dist/plugin/index.js
- FILEPATH/node_modules/esbuild-visualizer/dist/bin/cli.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (FILEPATH/node_modules/esbuild-visualizer/dist/plugin/module-mapper.js:4:22)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'FILEPATH/node_modules/esbuild-visualizer/dist/plugin/module-mapper.js',
    'FILEPATH/node_modules/esbuild-visualizer/dist/plugin/index.js',
    'FILEPATH/node_modules/esbuild-visualizer/dist/bin/cli.js'
  ]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I believe the nanoid package needs to be a dependency instead of a devDependency because the main bin file imports visualizer from plugin/index which imports ModuleMapper from plugin/module-mapper which imports customAlphabet from nanoid/non-secure

btd commented 3 years ago

Thank you