search

btd1337 / Stupendously-Hot-Charmander

Theme of the Charmander Project for Ubuntu OS
GNU General Public License v3.0
83 stars 4 forks source link

make the launcher icon square #1

Open rocketinventor opened 8 years ago

rocketinventor commented 8 years ago

In the Charmander Concept, the launcher icon is a square with edge to edge borders. This would mean that the launcher_bfb.svg icon would have to be converted from a circle to a square (easy to do with any SVG editor,) and it's orange borders would need to be extended.

btd1337 commented 8 years ago

In original concept the launcher icons is a circle, look this image.

original concept 11

When it is clicked, forms the orange square. Look:

original concept 12

rakshith-ravi commented 8 years ago

I'd start working on it. Would changing the svg file do it all?

btd1337 commented 8 years ago

This change affects more than svg file.

rocketinventor commented 8 years ago

@rakshithravi1997 If you look carefully at the launcher, you'll see that all icons have padding that's why it's more than svg. @btd1337 This would be CSS thing, right? I know CSS but, I've never done a Ubuntu theme before. What needs to be done? unity.css?

btd1337 commented 8 years ago

Read this: https://wiki.ubuntu.com/Unity/Theming http://www.linux.org/threads/installing-obtaining-and-making-gtk-themes.8463/ http://worldofgnome.org/how-to-hack-gnomes-adwaita-gtk-theme/

rakshith-ravi commented 8 years ago

@rocketinventor Agreed. Just tried changing the svg file and it does seem to have a margin. Not sure where the change the margin though. What if we were to give the Unity bar itself a background of the same colour just for the first icon? Wouldn't that solve the issue and make it look like there's no padding? Not sure if it's possible though @btd1337 This is not an enhancement. This is a necessity for the theme if we are making it as it is. Please remove the enhancement label

rocketinventor commented 8 years ago

@rakshithravi1997 If it's a theme, pretty much anything that is not a bug is an enhancement, right? @btd1337 I read through the articles and did some more research on it. In Unity 7+, only THEME_PATH/unity/launcher_bfb.{svg, png} can be customized. :frowning: It seems like the launcher source itself would have to be modified.

rakshith-ravi commented 8 years ago

@rocketinventor Agreed. But I just didn't want every issue to have an enhancement tag :P Let's just keep it for issues that might be good but isn't implemented in the original mock-up project.

I am a programmer myself. If you can provide me with links on how to modify the source code for the unity launcher itself, I'd be happy to implement it

btd1337 commented 8 years ago

I'm also learning about it...