search

btecu / ember-cli-bootstrap-datetimepicker

Ember date time picker addon
MIT License
20 stars 51 forks source link

Support for Ember 4x #110

Open nathanielasare opened 1 year ago

nathanielasare commented 1 year ago

Upgrading ember to 3.28.11 gives the warning below, and disabling jquery optional-features in favour of @ember/jquery breaks the picker.

WARNING: Setting the jquery-integration optional feature flag to true, or not providing a setting at all, has been deprecated. You must add the @ember/optional-features addon and set this feature to false. This warning will become an error in Ember 4.0.0.

I'm suppose to upgrade to ^4.4 and need a work around to get the date-picker to work with jquery-integration set to false. Thanks

btecu commented 1 year ago

Are you trying to remove jQuery? Unfortunately, https://github.com/Eonasdan/bootstrap-datetimepicker uses jQuery so it won't work without it.

nathanielasare commented 1 year ago

Are you trying to remove jQuery? Unfortunately, https://github.com/Eonasdan/bootstrap-datetimepicker uses jQuery so it won't work without it.

I'm trying to disable jQuery app wide and enable it when needed with @ember/jquery in components

btecu commented 1 year ago

As long as window.$ is set to jQuery, it should probably work.

nathanielasare commented 1 year ago

window.$ is set to jQuery

That is what I'm trying to avoid

btecu commented 1 year ago

That won't work because this addon uses the library https://github.com/Eonasdan/bootstrap-datetimepicker, which requires jQuery.