search

btel / SpikeSort

Spike sorting library implemented in Python/NumPy/PyTables
http://spike-sort.readthedocs.org
Other
27 stars 12 forks source link

Allow customizable thresholding procedure #50

Closed cpcloud closed 12 years ago

cpcloud commented 12 years ago

This is a VERY rough idea, but I've run in to an issue where I need to threshold each channel separately (we have many recordings that are not performed with tetrodes). It might be nice to have a parameter that allows one to run an arbitrary Python callable that conforms to the interface of detect_spikes.

belevtsoff commented 12 years ago

It might be nice to have a parameter that allows one to run an arbitrary Python callable that conforms to the interface of detect_spikes

Why not inherit a class from components.SpikeDetector and overload the _detect method instead? The overloaded method can include as many calls to detect_spikes as you have contacts and combine the output (if I understood you correctly)

But on the other hand, we could for example make the SpikeDetector receive a dict containing thresholds for every contact.

cpcloud commented 12 years ago

Sorry for adding all these issues. Clearly, I need to learn the API a little better.

belevtsoff commented 12 years ago

@cpcloud No reason to apologize. AFAIK, you're the only external person who currently takes part in the development. We're happy for any contributions :)