search

btford / grunt-google-cdn

58 stars 50 forks source link

Support for directory specified in .bowerrc #36

Open vilmosioo opened 11 years ago

vilmosioo commented 11 years ago

When specifying a different directory than simply 'components', it doesn't work

raitucarp commented 10 years ago

:+1:

danic89 commented 10 years ago

I don't quite understand the purpose of stripping path configured in .bowerrc. When I set as a sample: 'app/bower_components', the result CDN addres will be 'app///{google_cdn_address}'. I think that whole path configured in .bowerrc should be removed in order to have proper CDN address.

vilmosioo commented 10 years ago

The parsers does not recognize that path_to_components/angular.min.js is angular and it is not replaced in index.html with the CDN version.

danic89 commented 10 years ago

As I mentioned, when I have my bower components in path with separator the result path contains CDN version. This path cointains a part of my libs path as well.

Example:

my path:........app/libs/ {my bower components} js lib before:...app/libs/jquery/jquery.js js lib after:......app///ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js

vilmosioo commented 10 years ago

This has nothing to do with this ticket. Can you open a separate one please?