search

btholt / complete-intro-to-containers

The Complete Intro to Containers! As taught on Frontend Masters.
https://frontendmasters.com/courses/complete-intro-containers/
Other
940 stars 186 forks source link

add markdown extension to LICENSE #4

Closed leocaseiro closed 4 years ago

btholt commented 4 years ago

Hey @leocaseiro, thanks for the PR!

I often see LICENSE files without .md extensions and it looks like GitHub correctly links to the file in the header. Is there some reason that it needs the extension?

leocaseiro commented 4 years ago

Hey @btholt, the only reason I would suggest to rename is that it seems that your LICENSE file is using markdown format. However, without the extension .md, it doesn't look as nice when browsing on GH.

The link: https://github.com/btholt/complete-intro-to-containers/blob/master/LICENSE

Will show:

bholt-license

leocaseiro commented 4 years ago

Github accepts LICENSE.md https://help.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository#determining-the-location-of-your-license

btholt commented 4 years ago

Awesome! Thanks for finding that.