search

btholt / petfinder-client

Petfinder client that uses jsonp
4 stars 5 forks source link

Api for pet finder has changed #1

Closed kumaranando85 closed 6 years ago

kumaranando85 commented 6 years ago

Hi Brian, It seems that the pet finder api has changed and your method is returning undefined when required and also the key passed to the breed.list method is coming out to be undefined can you please suggest anything. Here is the url getting generated by the petfinder

http://api.petfinder.com/breed.list?key=undefined&format=json&animal=dog&callback=jsonp_e7rzr789d2zaw95

Your help would be highly appreciable.

Thanks

kumaranando85 commented 6 years ago

Hi Aasim, You just directly put the credentials in your file and not use process.env altogether. It worked for me.

Thanks, Kumar

On Sat, Sep 22, 2018 at 12:02 AM Aasim Attia notifications@github.com wrote:

@kumaranando85 https://github.com/kumaranando85 Any luck with that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/btholt/petfinder-client/issues/1#issuecomment-423631937, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRgeJvhTxsbtrJcqUNeFVGgdWNhfKlKks5udTDYgaJpZM4WWlD6 .

u5r0 commented 6 years ago

Yeah, I thought of that too. But I tried to switch package.json of the a03f523888 commit with mine temporarily then I ran npm install on it and it worked. Then I switched back to my package.json and ran npm install on it and it surprisingly worked too :smile:. I have no idea why or how :joy:

That's when I decided to delete my comment :smiley: Thanks for your time :smiley:

AIndoria commented 5 years ago

I know that you fixed it, but for anyone in future reading this and not wanting to waste time (Like I wasted about an hour looking around for solutions), restart your VSCode after installing ESLint, and then you can restart your server. This package won't work without doing t hat.