bthuronyi / CloneCoordinate

CloneCoordinate issue tracking
1 stars 0 forks source link

Fixing Minipreps m when the status is "No growth." (It still outputs "Ready to quantify" if I initial/date.) #122

Open ixf1 opened 3 months ago

ixf1 commented 3 months ago

When the Minipreps m status is "No growth," it still outputs "Ready to quantify" if I initial/date. We think there should be some kind of override.

santiagochrist commented 1 month ago

Solution: Place the line of code controlling that right below the manual statuses and right above the QC statuses.

=if(A753="","",
trim(ifs(
not(Q753),"certify queueing!",
FALSE,"Note: parts of the next block are duplicated in 'Prep from sequence-verified construct?'",
FALSE,"Read manual status assignments from the column that integrates these with any assigned in Sequencing",
CF753="! Conflicting manual statuses assigned to different instances of this mID in Sequencing!",CF753,
regexmatch(CF753,"(don't use)"),CF753,
regexmatch(CF753,"(hold)"),"wait; held"&if(H753=""," (from Sequencing)",""),
AG753="no","stalled - did not grow",
and(AS753<>"",AS753<settings_qcLowMiniprepConcCutoff),"Failed: low conc!",

What's very interesting is that after a regexmatch of the old statuses with the new ones, it seems that there are 20 ish minipreps that were quantified/purified/proceeded with despite not having grown any colonies :)

m751, m829, m852, m863, m864, m865, m872, m873, m1344, m1345, m1346, m1611, m1646, m1647, m1648, m1707, m1888, m1913, m1914, m1915, m1933, m1934, m2074

Screenshot 2024-08-02 at 10 31 15 AM

An interesting case is m1707, which had the wrong antibiotic or something like that, but placing the code below the antibiotic check (line 50 something of status) would bring back the original bug. With that being said, the code technically deals with it properly since the growth was marked as "no". If we want the antibiotic message to come back (may give more info, who knows) then we can just simply remove the "no" from the dropdown for "Grew?" and leave it blank. @bthuronyi