bthuronyi / CloneCoordinate

CloneCoordinate issue tracking
1 stars 0 forks source link

Warn if USER / anneal junctions are reverse complements of each other #161

Closed bthuronyi closed 2 months ago

bthuronyi commented 2 months ago

pBWT101 has USER and anneal junctions that are reverse complements of each other, so that it seems to me the anneal can (and did!) insert in either orientation. At some level, maybe even as far back as the dID that was generated using USER primers containing reverse complementary junctions, there should be warnings about this. It can be fine but it's a design that should be avoided in general because if the part goes in backwards people may not notice that and will think there's just some random insert.

bthuronyi commented 2 months ago

See maps for pBWT101 (original design) vs pBWT140 (annealed oligos insert in reverse orientation)

shen2333333 commented 2 months ago

I couldn't find pBWT140

shen2333333 commented 2 months ago

image So AgacgacT anneal junction is the issue...

shen2333333 commented 2 months ago

For the specific anneal dna, this does tell the story image

shen2333333 commented 2 months ago

image

shen2333333 commented 2 months ago

So if I'm understanding correctly, we don't want the junctions, the A........T (8-12 bases) to be reverse complement to be each other because then we can get inserts joined in reverse, which is what we don't want. And give warning to that

bthuronyi commented 2 months ago

I couldn't find pBWT140

Hmm maybe I accidentally made it in a folder not shared with the lab? I'll follow up

bthuronyi commented 2 months ago

So if I'm understanding correctly, we don't want the junctions, the A........T (8-12 bases) to be reverse complement to be each other because then we can get inserts joined in reverse, which is what we don't want. And give warning to that

Yes, correct - and actually whatever the lengths of the junctions are, we should warn if they are perfect reverse complement.

bthuronyi commented 2 months ago

I couldn't find pBWT140

Hmm maybe I accidentally made it in a folder not shared with the lab? I'll follow up

That was indeed the case. Fixed now.

shen2333333 commented 2 months ago

image Ah, that's it.

bthuronyi commented 2 months ago

Ah, that's it.

Yep. Had a real interesting time slowly realizing what had happened from the sequencing!

shen2333333 commented 2 months ago

Here's some ideas

https://docs.google.com/spreadsheets/d/1lhkEwbCgvcBTcsMinydFHJqrcuTSCYxowrtGUPQZmyY/edit?gid=25148367#gid=25148367

  1. I take advantage column Right junction sequence (5'>3', only 3' overhangs currently supported) and Left junction sequence (5'>3', only 3' overhangs currently supported) image For USER, I could use this formula to warn, =if(DNA_REVERSE_COMPLEMENT(AJ1186)=AK1186,"Warning: junctions are reverse complement",""); very useful for named function finding reverse complement

For anneal, I could use this formula image =LET( underscorepos, FIND("", AJ1205), first_part, LEFT(AJ1205, underscore_pos - 1), second_part, MID(AJ1205, underscore_pos + 1, LEN(AJ1205) - underscore_pos), IF(ISNUMBER(underscore_pos), IF(first_part = second_part, "Warning: junctions are reverse complement", ""), "" ) )

But I think to actually warn user, somehow it needs to be incorporated into the giant "Queueing validity check"? which I'm not quite sure how to approach.

bthuronyi commented 2 months ago

Implemented along the lines you laid out. Had to change the junction determination formulas so they are active before Certify correct queued is checked off; also updated them to more modern coding practices.

bthuronyi commented 2 months ago

As so often happens when we introduce new automated warnings, 24 different dsDNA fragments were queued in the past that have reverse-complementary junctions, affecting 13 constructs...