bthuronyi / CloneCoordinate

CloneCoordinate issue tracking
1 stars 0 forks source link

Sweep through all green/blue columns and make sure Named Range exists #182

Closed bthuronyi closed 3 months ago

bthuronyi commented 3 months ago

Sweep through all green/blue columns and make sure Named Range exists

santiagochrist commented 3 months ago
bthuronyi commented 3 months ago

Great! I will get these named momentarily. The Sort # fields are the one exception where they are both user data and also considered temporary so we don't copy them from instance to instance. Though I guess there is not a strong justification for that so maybe I will just name them too to be consistent.

bthuronyi commented 3 months ago

Sorry I messed up the comment formatting and there is apparently no straight-up "revert edit" function...

bthuronyi commented 3 months ago

Note: a lot of named ranges still use the old "USER_x_y_Z" format, may want to change that.

Yeah, it's on the list, but changing any named range names creates issues at the moment, so we need a script to sort through it #82 #171

bthuronyi commented 3 months ago

Can you also look at Settings and admin? It's much more of a mess in there, but the blue/green highlight scheme still holds true, for individual cells typically or sometimes ranges or columns.

santiagochrist commented 3 months ago

Sorry I messed up the comment formatting and there is apparently no straight-up "revert edit" function...

I thought there'd be an edit history like when you include code, but I guess not...

bthuronyi commented 3 months ago

I thought there'd be an edit history like when you include code, but I guess not...

It does provide an edit history but not in the correct markdown and only as a diff -- so you can't just straight up copy and paste back an old version. Apparently a known Github issue, not fixed/implemented yet.

santiagochrist commented 3 months ago

I may have been somewhat overkill with this list, but I think I spotted almost everything that raised flags to me.

Settings & admin:

bthuronyi commented 3 months ago
  • Column I:K (none of these values): Dashboard info, although this pulls from dashboard and outputs it onto settings, I thought it'd maybe be the other way around but oh well just thought I'd note it.

Yeah, this is a bit of a mess and I need to back up and rethink how it's gonna work -- but, noted!

bthuronyi commented 3 months ago
  • [x] - Column L: Registry: Project list dropdown (do we want to named range this and output the array??)

This is actually a named range that starts in row 2; it's ok as-is. I adjusted it to go to the bottom row.

bthuronyi commented 3 months ago
  • [ ] - Column N: Registry: Antibiotics table (is this purely for human reference and unused?)

Also a not-full-column Named Range

bthuronyi commented 3 months ago
  • [x] - Column X: dsDNA thermocycler block dropdown options

Didn't go to row 200; fixed

bthuronyi commented 3 months ago
    • Column AA:AZ: Nothing in here is named, is this all just human reference or do we have a really ugly, non- named range references?

Non-full-column Named Ranges

bthuronyi commented 3 months ago
  • [ ] - Column BC:BD: QC Agarose gel ladders

Non-full-column Named Ranges

bthuronyi commented 3 months ago
  • CP7:C13: Plasmid, miniprep volume stuff

This was quite a mess -- some cells were unused and the equivalent value hardcoded in! All sorted now.

bthuronyi commented 3 months ago
  • [ ] - Column I:K (none of these values): Dashboard info, although this pulls from dashboard and outputs it onto settings, I thought it'd maybe be the other way around but oh well just thought I'd note it.

Remaining problem

bthuronyi commented 3 months ago

Moved remaining task to new issue.