search

btimby / py-radius

RADIUS authentication module
Other
62 stars 38 forks source link

Add IPv6 support #14

Closed fhidalgosola closed 5 years ago

fhidalgosola commented 6 years ago

Simply added some arguments to accept opening IPv6 sockets.

Unsure if the way I'm handling the unit tests for both AF is acceptable, happy to modify.

btimby commented 6 years ago

Thanks for the contribution! I will think this over, but it might be nice to accept an optional socket argument so that caller can completely control the network connection if they desire that.

What do you think?

fhidalgosola commented 6 years ago

I imagine you mean accepting a socket as an additional parameter to the already existing basic settings, right? I think that probably makes sense, however, I'd argue that nowadays being able to use IPv6 is quite basic. Either way it's going to work for me.

fhidalgosola commented 6 years ago

@btimby wonder if you think could be accepted as is or with some modifications or if I should do my own. I actually want to use this at Facebook for authentication testing and prefer to use the upstream version if at all possible.

graingert commented 5 years ago

@fhidalgosola hey I merged your PR into my fork at https://github.com/graingert/py-radius and you can install it with pip install radius