search

btimofeev / UniPatcher

A game console ROM patcher for Android
GNU General Public License v3.0
155 stars 18 forks source link

Refactor Member Ignoring Method smell in FilePickerActivity class #17

Closed emaiannone closed 4 years ago

emaiannone commented 4 years ago

Hi, I'm Emanuele Iannone, a master student at University of Salerno. Since my bachelor's thesis I have been working on a code smell refactoring plugin called aDoctor, which is able to identify and fix energy-related problems in Android apps. I launched it on your project, finding different instances of code smells. I chose one of them and let the plugin automatically fix it. In this case I chose Member Ignoring Method, that is present when a non static method does not use at all instance variables and other non static methods. These kind of smell may have a non trivial impact on energy consumption, as shown in this paper: https://www.sciencedirect.com/science/article/pii/S0950584918301678. Besides, this kind of refactoring does not impact on the functionalities of your app, so it is totally safe. Let me know if you are interested in this refactoring proposal.

btimofeev commented 4 years ago

Thanks. I will look at your plugin. Unfortunately, I can not accept your pull request, as I will soon delete the entire FilePickerActivity.java class.