Fix to the local variables bug (#12) - Githubissues

btk5h / skript-db

MIT License

5 stars 5 forks source link

Fix to the local variables bug (#12) #14

Open FranKusmiruk opened 5 years ago

FranKusmiruk commented 5 years ago

Whereas this fix isn't ideal, it does fix the issue with local variables, I honestly didn't think a lot about a better solution so I am open to suggestions.

The aim of the PR besides fixing this bug is:

Updating the build.gradle dependencies.
Removing support for 2.2 series (since supporting it at this point would make this a real mess).
Fixing a bug with the recently added timeout feature (currently throws a NPE since you've forgot to declare the input expression as nullable in the pattern).

btk5h commented 5 years ago

Sorry for just getting to this now, this fix looks good, though executeStatement should return the variables it needs to modify instead of keeping that information inside of a field.