search

btm / minitest-handler-cookbook

Apache License 2.0
59 stars 36 forks source link

Add Minitest Handler options as attributes #28

Closed juanje closed 11 years ago

juanje commented 11 years ago

Right now the MiniTest Handler's option verbose is harcoded in the recipe and the only option that can be configured is the path.

I found particulary annoying the option verbose so I created an attribute to be able of change it. But also I've added the possibility to pass the rest of the options as attributes in your recipe, role or wherever.

As the other options have default values or they are not always used, I just add the posibility to pass them, but I didn't add an attribute. Mostly to avoid overwrite the default values from the minitest itself.

I hope you like the feature and I'll be happy to make any changes you ask me. Cheers

bryanwb commented 11 years ago

tks @juanje !!

bryanwb commented 11 years ago

@juanje think u can also find time to update the README?

juanje commented 11 years ago

@bryanwb, I'm quite busy right now, but I'll try to find time for that. It need some updates. Thanks for the merge! :smile:

bryanwb commented 11 years ago

np, i understand the busy part. hello from Istanbul!

hope to c u at FOSDEM

On Mon, Dec 24, 2012 at 9:03 AM, Juanje Ojeda notifications@github.comwrote:

@bryanwb https://github.com/bryanwb, I'm quite busy right now, but I'll try to find time for that. It need some updates. Thanks for the merge! [image: :smile:]

— Reply to this email directly or view it on GitHubhttps://github.com/btm/minitest-handler-cookbook/pull/28#issuecomment-11655874.