btmills / react-datamaps

React component for D3 DataMaps
MIT License
31 stars 22 forks source link

Can we enable keyboard support to this package? #40

Open arunmmanoharan opened 5 years ago

arunmmanoharan commented 5 years ago

Hi,

I was trying out a few map packages and this is the best I've seen. I work on a project where keyboard and screen reader support is of more importance. Is there a way we/you can implement this?

Looking forward to your thoughts.

Currently react-simple-maps supports just keyboard navigation using tabs alphabetically by state.

btmills commented 5 years ago

This aims to be a very thin wrapper around https://github.com/markmarkoh/datamaps, so I'd be happy to accept a pull request that enables anything that already exists in that project.

For some historical perspective, I created this to migrate an existing project that used datamaps to React with as little re-writing as possible. react-simple-maps looks like a really nice API, so if I ever need to build something else with maps, I'll take a look at that - thanks for the tip!

arunmmanoharan commented 5 years ago

Thanks man. Appreciate the help.