search

btoews / OctoGAS

GitHub Email Notifications Google Apps Script for Gmail
100 stars 22 forks source link

Implement archiving #8

Closed parkr closed 10 years ago

parkr commented 10 years ago

This, of course, changes the workflow a bit for the user, but it also makes notifications nicer because they're accessed with some amount of volition, rather than just piling up in your inbox. It also allows you to tackle the one repo/etc rather than going through everything in your inbox.

A thought!

pborreli commented 10 years ago

:+1:

btoews commented 10 years ago

I think our workflows are a bit different, but I can see where this would be useful. A few things before I merge.

  1. People are already running into rate limit issues, so it's best to cut down on API calls. Can Thread.archiveAll call GmailApp.moveThreadsToArchive with the whole list of threads instead of on threads individually?
  2. Can we hide this behind a flag so the default behavior isn't changed?
  3. Can you update the README.md to describe the change and how to enable it.
  4. Can you run script/compile and commit the changes to the compiled code.
parkr commented 10 years ago

@mastahyeti Just pushed up some new code to address your comments. What do you think?

btoews commented 10 years ago

Looks great. Thanks!

parkr commented 10 years ago

Thank you!