search

btoews / security-key

iOS SEP U2F
MIT License
78 stars 14 forks source link

Updated project so that it builds Xcode 8 #3

Closed radazzouz closed 8 years ago

radazzouz commented 8 years ago

This branch builds properly with Xcode 8 beta 6. Let's not merge this PR yet.

I will test this branch with upcoming versions of Xcode 8. We should merge it as soon as Xcode 8 hits the Mac App Store.

btoews commented 8 years ago

Whoops. Just saw this. I guess I should be watching this repo :smile:

I ran the conversion tool again in Xcode to see if there were any changes from the beta. The signature of doneWithResults in ActionRequestHandler.swift got changed to

func doneWithResults(_ resultsForJavaScriptFinalizeArg: [AnyHashable: Any]?) {

This removes the need for the as NSObject and as AnyObject changes from this branch. Here's the diff between the new conversion results and this branch. I'll go ahead and close this PR and open a new one with the new conversion.