search

btolab / hypseus

Hypseus is a fork of Daphne. A program that "lets one play the original versions of many laserdisc arcade games on one's PC."
GNU General Public License v3.0
18 stars 7 forks source link

Scoreboard overlay incorrect position and missing text #18

Open OzFalcon opened 6 years ago

OzFalcon commented 6 years ago

Scoreboard overlay incorrect position and missing text (Credits, Lives, Player #) As per the attached image hypseus_overlay

Using latest master/commit https://github.com/btolab/hypseus/tree/c6af13b1274bbeb3e0406c84db6b9a5b3ce0bc72

vanfanel commented 3 years ago

@OzFalcon @h0tw1r3 I would like to investigate this. Scoreboard is being drawn in:

https://github.com/btolab/hypseus/blob/3f7c4cbad8e36c3babf230321de9e67dee100767/src/video/video.cpp#L408

The leds are drawn onto g_leds_surface, which is created here: https://github.com/btolab/hypseus/blob/3f7c4cbad8e36c3babf230321de9e67dee100767/src/video/video.cpp#L235 As you can see, it's created as a 320x240 surface, and blitted onto g_overlay_texture with a 320x240 rect accordingly.

So, maybe the LED surface size is wrong? Maybe the blitting dimensions are wrong? Any ideas are welcome.

vanfanel commented 3 years ago

@h0tw1r3 Do you have any clues on why Dragon's Lair 2 isn't displaying the hiscore tables? Thought it was working in Daphne, or maybe it's also missing upstream?

According to this thread: https://www.daphne-emu.com:9443/phpBB3/viewtopic.php?t=2384 ...overlay in DL2 should be available from 2007

Further investigation indicates that DL2 overlays should be working. Seems like things are in place.

lair2 is defined as using overlays as in Daphne:

https://github.com/btolab/hypseus/blob/3f7c4cbad8e36c3babf230321de9e67dee100767/src/game/lair2.cpp#L220

https://github.com/DavidGriffith/daphne/blob/36752844655cebd3d9da7ae422325bdbee93634c/src/game/lair2.cpp#L304

A call to video_blit() when overlay update is needed is in place in both cases:

https://github.com/btolab/hypseus/blob/3f7c4cbad8e36c3babf230321de9e67dee100767/src/game/lair2.cpp#L690

https://github.com/DavidGriffith/daphne/blob/36752844655cebd3d9da7ae422325bdbee93634c/src/game/lair2.cpp#L804

So, what's missing on Hypseus??

h0tw1r3 commented 3 years ago

Unless something has changed recently, this is not implemented upstream. Overlay doesn't imply a scoreboard, but the scoreboard does require overlay support.

h0tw1r3 commented 3 years ago

I also found this information, which seems interesting for enabling the game overlays in dlair2. https://www.daphne-emu.com:9443/phpBB3/viewtopic.php?t=2384