btrask / stronglink

A searchable, syncable, content-addressable notetaking system
Other
1.04k stars 39 forks source link

Error logging is synchronous/blocking #57

Closed btrask closed 8 years ago

btrask commented 9 years ago

We use evented I/O with fibers sharing a single main thread. However currently we just use fprintf for logging. I don't think this is a big deal but we should look into it at some point.

Note that Linux supports fopencookie and BSD supports something similar but different, so we could write a non-blocking wrapper around stderr and keep using the existing fprintfs. Might have portability problems though.

Tagging this security since in theory it could result in a denial of service attack.

btrask commented 8 years ago

Fixed partially, except see #100.