btrask / stronglink

A searchable, syncable, content-addressable notetaking system
Other
1.04k stars 45 forks source link

Potentially malicious links in Markdown previews are clickable #99

Open btrask opened 8 years ago

btrask commented 8 years ago

In our preview generator for CommonMark Markdown files, we allow clickable links, including hash: links. That means we don't use cmark's "safe" link checker that prohibits javascript: links, among other protocols.

We should probably maintain our own whitelist.

Let's look at cmark to see what else.